Re: [CSplus/RelationshipCRM] feat: Gmail連携(読み取り専用OAuth・差分同期・自動紐付け) (PR #11)
- 相手(連絡先)
- -
- 会社
- -
- From(Gmail)
- notifications@github.com
- To / Cc(Gmail)
- relationshipcrm@noreply.github.com, koshiba@csplus.jp, author@noreply.github.com
- 作成日時
- 2026/07/12 11:08
- 更新日時
- 2026/07/12 11:08
本文
@chatgpt-codex-connector[bot] commented on this pull request. ### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `dff2b02bbb` <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details> > + const contactByEmail = new Map( + contacts.map((c) => [c.email!.toLowerCase(), c]), + ); **<sub><sub></sub></sub> Preserve duplicate-email ambiguity during auto-linking** When two contacts share the same email address, this `Map` keeps only the last row because `Contact.email` is not unique in the schema. A Gmail message from/to that address will therefore be treated as `matched.size === 1` and auto-linked to an arbitrary contact, even though the sync contract says ambiguous multiple matches should remain unlinked; group contacts by normalized email and mark addresses with more than one contact as ambiguous instead of overwriting them. Useful? React with 👍 / 👎. -- Reply to this email directly or view it on GitHub: https://github.com/CSplus/RelationshipCRM/pull/11#pullrequestreview-4678069897 You are receiving this because you authored the thread. Message ID: <CSplus/RelationshipCRM/pull/11/review/4678069897@github.com>