Re: [CSplus/RelationshipCRM] feat: 交流会(NetworkingEvent)の編集・削除機能 (PR #7)
- 相手(連絡先)
- -
- 会社
- -
- From(Gmail)
- notifications@github.com
- To / Cc(Gmail)
- relationshipcrm@noreply.github.com, koshiba@csplus.jp, author@noreply.github.com
- 作成日時
- 2026/07/12 11:08
- 更新日時
- 2026/07/12 11:08
本文
@chatgpt-codex-connector[bot] commented on this pull request. ### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `e8bb46226c` <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details> > + const participantCount = await prisma.contactNetworkingEvent.count({ + where: { networkingEventId: id }, + }); **<sub><sub></sub></sub> Make participant check atomic with delete** This count is used as the only server-side guard before the later `networkingEvent.delete`, so a participant added by another tab/request after the count returns 0 but before the delete will still be removed by the schema's cascading `ContactNetworkingEvent` relation. In that race, the delete succeeds despite the “participants block deletion” guarantee and can also detach related business-card links, so the guard should be enforced atomically with the delete (for example via locking/transactional logic or a restrictive FK). Useful? React with 👍 / 👎. -- Reply to this email directly or view it on GitHub: https://github.com/CSplus/RelationshipCRM/pull/7#pullrequestreview-4677662200 You are receiving this because you authored the thread. Message ID: <CSplus/RelationshipCRM/pull/7/review/4677662200@github.com>