Re: [CSplus/RelationshipCRM] feat: 交流会管理機能(一覧・作成・詳細・参加者登録・exchangedAt・名刺一括登録の土台) (PR #2)
- 相手(連絡先)
- -
- 会社
- -
- From(Gmail)
- notifications@github.com
- To / Cc(Gmail)
- relationshipcrm@noreply.github.com, koshiba@csplus.jp, author@noreply.github.com
- 作成日時
- 2026/07/12 11:08
- 更新日時
- 2026/07/12 11:08
本文
@chatgpt-codex-connector[bot] commented on this pull request. ### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `bfcaa4edba` <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details> > + rank: string; +}; + +/** + * 参加者追加用の連絡先検索。 + * 検索は ContactSearchProvider 経由で行い、登録済みの参加者は除外する。 + */ +export async function searchParticipantCandidates( + eventId: string, + keyword: string, +): Promise<ParticipantCandidate[]> { + const trimmed = keyword.trim(); + if (!trimmed) return []; + + const [result, existing] = await Promise.all([ + contactSearch.search({ keyword: trimmed, perPage: 20 }), **<sub><sub></sub></sub> Move participant exclusion before the result cap** This search only fetches the first 20 contact matches and then filters out contacts already registered for the event below. For a common keyword where those first 20 matches are all existing participants, later matching contacts never reach the picker, so the UI reports no candidates even though addable contacts exist. Exclude existing contact IDs in the underlying query or fetch enough rows before slicing to the 10 displayed candidates. Useful? React with 👍 / 👎. -- Reply to this email directly or view it on GitHub: https://github.com/CSplus/RelationshipCRM/pull/2#pullrequestreview-4676937834 You are receiving this because you authored the thread. Message ID: <CSplus/RelationshipCRM/pull/2/review/4676937834@github.com>